linux-kernel - Re: 2.6.23: x86_64 oops caused by hotplug running before vdso initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200712062151.55480.ak@suse.de>
Date:	Thu, 6 Dec 2007 21:51:55 +0100
From:	Andi Kleen <ak@...e.de>
To:	Chuck Ebbert <cebbert@...hat.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.23: x86_64 oops caused by hotplug running before vdso initialized

On Thursday 06 December 2007 20:44:46 Chuck Ebbert wrote:
> pages is NULL here, implying vma->vm_private_data was NULL. This is apparently
> because init_vdso_vars() is __initcall and runs after the rootfs gets populated.
> An experimental initrd containing an /sbin/hotplug binary caused this. Normally
> we don't have that file in the initrd. Should vdso init be done earlier to prevent
> this problem?

We've often had bugs like this. Sure it could be fixed here, but then
the next bug would crop up again later I bet.

It would be better to move the first user  space code execution later I think. 
I guess the hotplug events could be delayed or initrd just mounted later.

Running any user space before __initcall() has finished is just wrong.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/