linux-kernel - Re: [PATCH] scheduler: fix x86 regression in native_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071207111215.GA9502@elte.hu>
Date:	Fri, 7 Dec 2007 12:12:15 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Stefano Brivio <stefano.brivio@...imi.it>,
	Robert Love <rml@...h9.net>, linux-kernel@...r.kernel.org,
	Dave Jones <davej@...hat.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Michael Buesch <mb@...sch.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH] scheduler: fix x86 regression in native_sched_clock


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> > > A bit risky - it's quite an expansion of code which no longer can 
> > > call printk.
> > > 
> > > You might want to take that WARN_ON out of __update_rq_clock() ;)
> > 
> > hm, dont we already detect printk recursions and turn them into a 
> > silent return instead of a hang/crash?
> 
> We'll pop the locks and will proceed to do the nested printk.  So 
> __update_rq_clock() will need rather a lot of stack ;)

yeah. That behavior of printk is rather fragile. I think my previous 
patch should handle all such incidents.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/