lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Dec 2007 15:28:17 -0600 From: Olof Johansson <olof@...om.net> To: Balbir Singh <balbir@...ux.vnet.ibm.com> Cc: linuxppc-dev@...abs.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] Fake NUMA emulation for PowerPC Hi, On Sat, Dec 08, 2007 at 02:44:25AM +0530, Balbir Singh wrote: > Comments are as always welcome! Care to explain what this is useful for? (Not saying it's a stupid idea, just wondering what the reason for doing it is). > diff -puN arch/powerpc/mm/numa.c~ppc-fake-numa-easy arch/powerpc/mm/numa.c > --- linux-2.6.24-rc4-mm1/arch/powerpc/mm/numa.c~ppc-fake-numa-easy 2007-12-07 21:25:55.000000000 +0530 > +++ linux-2.6.24-rc4-mm1-balbir/arch/powerpc/mm/numa.c 2007-12-08 02:36:02.000000000 +0530 > @@ -24,6 +24,8 @@ > > static int numa_enabled = 1; > > +char *cmdline __initdata; > + Looks like this should be static. > @@ -702,6 +744,9 @@ static int __init early_numa(char *p) > if (strstr(p, "debug")) > numa_debug = 1; > > + if (strstr(p, "fake=")) > + cmdline = p + 5; /* 5 is faster than strlen("fake=") */ This doesn't look right. You check if it contains fake=, not if it starts with it. So if someone did: "numa=foo,fake=bar", or even "numa=debug,fake=", things wouldn't work right. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists