linux-kernel - Re: [PATCH] Fake NUMA emulation for PowerPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1197063225.6078.54.camel@moss-terrapins.epoch.ncsc.mil>
Date:	Fri, 07 Dec 2007 16:33:45 -0500
From:	Dave Quigley <dpquigl@...ho.nsa.gov>
To:	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Cc:	Balbir Singh <balbir@...ux.vnet.ibm.com>, linuxppc-dev@...abs.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fake NUMA emulation for PowerPC


On Fri, 2007-12-07 at 22:30 +0100, Geert Uytterhoeven wrote:
> On Sat, 8 Dec 2007, Balbir Singh wrote:
> > +	if (strstr(p, "fake="))
> > +		cmdline = p + 5;	/* 5 is faster than strlen("fake=") */
> 
> Really? My gcc is smart enough to replace the `strlen("fake=")' by 5, even
> without -O.

If some odd reason it doesn't replace it wouldn't it be smarter to do
sizeof("fake="); It should definitely optimize that away to a constant
value and its less prone to error if the string in strstr changes.

> 
> With kind regards,
>  
> Geert Uytterhoeven
> Software Architect
> 
> Sony Network and Software Technology Center Europe
> The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
>  
> Phone:    +32 (0)2 700 8453	
> Fax:      +32 (0)2 700 8622	
> E-mail:   Geert.Uytterhoeven@...ycom.com	
> Internet: http://www.sony-europe.com/
>  	
> Sony Network and Software Technology Center Europe	
> A division of Sony Service Centre (Europe) N.V.	
> Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
> VAT BE 0413.825.160 · RPR Brussels	
> Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/