lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1197132792.1568.162.camel@jnielson-xp.ddns.mvista.com> Date: Sat, 08 Dec 2007 08:53:12 -0800 From: Daniel Walker <dwalker@...sta.com> To: Peter Zijlstra <peterz@...radead.org> Cc: Remy Bohmer <linux@...mer.net>, Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>, linux-kernel <linux-kernel@...r.kernel.org>, Dave Chinner <dgc@....com> Subject: Re: lockdep problem conversion semaphore->mutex (dev->sem) On Sat, 2007-12-08 at 13:16 +0100, Peter Zijlstra wrote: > On Sat, 2007-12-08 at 00:02 +0100, Remy Bohmer wrote: > > Hello Peter, > > > > > > What specifically is wrong with dev->sem ? > > > > > > Nothing really, other than that they use semaphores to avoid lockdep :-/ > > > > > > I think I know how to annotate this, after Alan Stern explained all the > > > use cases, but I haven't come around to implementing it. Hope to do that > > > soonish. > > > > I was looking for an easy semaphore I could convert to a mutex, and I > > ran into one that was widely spread and interesting, and which seemed > > quite doable at first sight. > > So, I started working on it, but was forgotten this discussion, (until > > Daniel made me remember it this afternoon). So, I (stupid me ;-) ) > > tried to convert dev->sem... > > > > After doing the monkey part of the conversion I can boot the kernel > > completely on X86 and ARM, and everything works fine, except after > > enabling lockdep, lockdep starts complaining... > > > > Is this the problem you were pointing at? > > Yeah, one of the interesting nestings :-) It must be the locking in __driver_attach(), taking dev->parent->sem then taking dev->sem .. Assuming those are different structures, why does lockdep trigger? Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists