lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <475A5188.6070809@gmail.com> Date: Sat, 08 Dec 2007 09:10:48 +0100 From: Jiri Slaby <jirislaby@...il.com> To: Ingo Molnar <mingo@...e.hu> CC: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>, Arjan van de Ven <arjan@...ux.intel.com>, Thomas Gleixner <tglx@...utronix.de>, Linux-pm mailing list <linux-pm@...ts.linux-foundation.org> Subject: Re: broken suspend (sched related) [Was: 2.6.24-rc4-mm1] On 12/07/2007 06:51 PM, Ingo Molnar wrote: > * Ingo Molnar <mingo@...e.hu> wrote: > >> thanks for tracking it down. Does the patch below help? > > oops, that should be the patch below. Otherwise the watchdog kernel > threads will just loop around. > > Ingo > > --- > kernel/softlockup.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > Index: linux/kernel/softlockup.c > =================================================================== > --- linux.orig/kernel/softlockup.c > +++ linux/kernel/softlockup.c > @@ -101,7 +101,11 @@ void softlockup_tick(void) > > now = get_timestamp(this_cpu); > > - /* Warn about unreasonable delays: */ > + /* Wake up the high-prio watchdog task every second: */ > + if (now > (touch_timestamp + 1)) > + wake_up_process(per_cpu(watchdog_task, this_cpu)); > + > + /* Warn about unreasonable 10+ seconds delays: */ > if (now <= (touch_timestamp + softlockup_thresh)) > return; > > @@ -213,8 +217,9 @@ static int watchdog(void *__bind_cpu) > * debug-printout triggers in softlockup_tick(). > */ > while (!kthread_should_stop()) { > + set_current_state(TASK_INTERRUPTIBLE); > touch_softlockup_watchdog(); > - msleep_interruptible(10000); > + schedule(); > > /* > * Only do the hung-tasks check on one CPU: Unfortunately no change here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists