linux-kernel - Re: [PATCH 2.6.24-rc4-mm 2/2] gpiolib: add Generic IRQ support for 16-bit PCA9539 GPIO expander

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200712100214.52478.david-b@pacbell.net>
Date:	Mon, 10 Dec 2007 02:14:52 -0800
From:	David Brownell <david-b@...bell.net>
To:	"eric miao" <eric.y.miao@...il.com>
Cc:	"Linux Kernel list" <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.arm.linux.org.uk>,
	i2c@...sensors.org
Subject: Re: [PATCH 2.6.24-rc4-mm 2/2] gpiolib: add Generic IRQ support for 16-bit PCA9539 GPIO expander

On Monday 10 December 2007, eric miao wrote:
> +config GPIO_PCA9539_GENERIC_IRQ
> +       bool "    Generic IRQ support for PCA9539"
> +       depends on GPIO_PCA9539=y

Also depends on GENERIC_HARDIRQS, right?  (You should let
the Kconfig UI handle indentation, too...)

Seems like doing this for an I2C chip ought to shake loose
some interesting review comments.  :)


> +       help
> +         Say yes here to support the Generic IRQ for the PCA9539 on-chip
> +         GPIO lines.

This somewhat resembles the pcf857x chips in that it only support
pin-changed IRQs (IRQ_TYPE_EDGE_BOTH) in hardware.  Some other I/O
expanders are a bit more flexible.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/