linux-kernel - Re: [PATCH][SCSI] hptiop: add more adapter models and other fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071210165030.GB26334@parisc-linux.org>
Date:	Mon, 10 Dec 2007 09:50:30 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	HighPoint Linux Team <linux@...hpoint-tech.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	James.Bottomley@...elEye.com
Subject: Re: [PATCH][SCSI] hptiop: add more adapter models and other fixes

On Mon, Dec 10, 2007 at 01:54:53PM +0800, HighPoint Linux Team wrote:
> Most code changes were made to support adapters based on Marvell IOP, plus some
> other fixes.
> 
> - add more PCI device IDs
> - support for adapters based on Marvell IOP

Are you sure it's a good idea to do this?  This patch is 1200 lines long
... the same size as the existing driver:

$ wc drivers/scsi/hptiop.*
  947  2273 24531 drivers/scsi/hptiop.c
  256   612  6175 drivers/scsi/hptiop.h
  1203  2885 30706 total

That suggests to me there's not much commonality between the two drivers,
and you'd be better off adding a second driver for the 4xxx cards.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/