lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Dec 2007 19:50:08 +0100 From: Sam Ravnborg <sam@...nborg.org> To: Andi Kleen <ak@...e.de> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, rusty@...tcorp.com.au Subject: Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: > > This way gcc can warn for wrong format strings This loks good. Can I get i s-o-b then I will apply it. Sam > > --- > scripts/mod/modpost.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > Index: linux/scripts/mod/modpost.c > =================================================================== > --- linux.orig/scripts/mod/modpost.c > +++ linux/scripts/mod/modpost.c > @@ -33,7 +33,9 @@ enum export { > export_unused_gpl, export_gpl_future, export_unknown > }; > > -void fatal(const char *fmt, ...) > +#define PRINTF __attribute__ ((format (printf, 1, 2))) > + > +PRINTF void fatal(const char *fmt, ...) > { > va_list arglist; > > @@ -46,7 +48,7 @@ void fatal(const char *fmt, ...) > exit(1); > } > > -void warn(const char *fmt, ...) > +PRINTF void warn(const char *fmt, ...) > { > va_list arglist; > > @@ -57,7 +59,7 @@ void warn(const char *fmt, ...) > va_end(arglist); > } > > -void merror(const char *fmt, ...) > +PRINTF void merror(const char *fmt, ...) > { > va_list arglist; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists