linux-kernel - Re: Correct types for mod_devicetable.h (was: Re: m68k build failure)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071210201259.1ad466c7@poseidon.drzeus.cx>
Date:	Mon, 10 Dec 2007 20:12:59 +0100
From:	Pierre Ossman <drzeus@...eus.cx>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Al Viro <viro@....linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Marcel Holtmann <marcel@...tmann.org>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	linux-arch@...r.kernel.org
Subject: Re: Correct types for mod_devicetable.h (was: Re: m68k build
 failure)

On Mon, 10 Dec 2007 19:11:12 +0100
Adrian Bunk <bunk@...nel.org> wrote:

> On Sun, Dec 09, 2007 at 06:08:18PM +0100, Pierre Ossman wrote:
> > 
> > This still requires a bit of maintenance to set up a kerneltypes.h for every arch.
> 
> Better doing this work once than fixing similar issues again and again.
> 

Agreed. But it raises the bar quite a bit to get this ready for upstream.

> > It also means we have to be very careful that gcc's internal alignment settings matched the ones in our header.
> 
> There's nothing "gcc internal" about struct alignment - remember that 
> any change in struct alignment would change our userspace ABI.
> 

Oh? I would have guessed that everything going to and from userspace would be packed. Should probably consider myself lucky I have do deal with few such interactions. :)

Rgds
Pierre

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)