linux-kernel - Re: RT Load balance changes in sched-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <475C8EE9.2040608@redhat.com>
Date:	Sun, 09 Dec 2007 19:57:13 -0500
From:	Steven Rostedt <srostedt@...hat.com>
To:	Gregory Haskins <ghaskins@...ell.com>
CC:	Dmitry Adamushko <dmitry.adamushko@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, Balbir Singh <balbir@...ibm.com>,
	vatsa@...ux.vnet.ibm.com,
	LKML Kernel <linux-kernel@...r.kernel.org>
Subject: Re: RT Load balance changes in sched-devel

Gregory Haskins wrote:
>> btw., both cases would be addressed by placing load-balance points
>> into sched_class_rt->{enqueue,dequeue}_task_rt()... push_rt_tasks()
>> and pull_rt_tasks() respectively. As a side effect (I think,
>> technically, it would be possible), 3 out of 4 *_balance_rt() calls
>> (the exception: schedule_tail_balance_rt()) in schedule() would become
>> unnecessary.
>>
>> _BUT_
>>
>> the enqueue/dequeue() interface would become less straightforward,
>> logically-wise.
>> Something like:

Also push and pull_rt use activate,deactivate as well. So this would 
make that code a bit more complex.

>>
>> rq = activate_task(rq, ...) ; /* may unlock rq and lock/return another one 
>> */
>>
>> would complicate the existing use cases.
>>
> 
> I think I would prefer to just fix the setscheduler/setprio cases for the class transition than change the behavior of these enqueue/dequeue calls.  But I will keep an open mind as I look into this issue.

I agree with Gregory on this. I prefer to fix the two you found. I 
thought about them before, but somehow they were missed :-/

Anyway, I'll be working on adding some more patches on Monday. There may 
be other ways to clean this up.

> 
> Thanks for the review!

Yeah, thanks from me too!

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/