linux-kernel - Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels on boot cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440712111045j1384930ak77f06f4c7336aae7@mail.gmail.com>
Date:	Tue, 11 Dec 2007 10:45:01 -0800
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Neil Horman" <nhorman@...driver.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Ben Woodard" <woodard@...hat.com>,
	"Neil Horman" <nhorman@...hat.com>, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org, "Andi Kleen" <ak@...e.de>,
	hbabu@...ibm.com, "Andi Kleen" <andi@...stfloor.org>
Subject: Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels on boot cpu

On Dec 11, 2007 10:29 AM, Neil Horman <nhorman@...driver.com> wrote:
>
> On Tue, Dec 11, 2007 at 10:00:00AM -0800, Yinghai Lu wrote:
> > On Dec 11, 2007 7:29 AM, Eric W. Biederman <ebiederm@...ssion.com> wrote:
> > >
> > > I'm actually inclined to remove the return magic and just do something
> > > like:
> > >         static fix_applied;
> > >         if (fix_applied++)
> > >                 return;
> > > In those functions that should be called only once.
> >
> > it seems we need to have two tables. one for northbridge (sweep all
> > the NB_K8) and another for SB ( like Nvidia, ati..., one touch and
> > leave)
> >
> > YH
> >
> I like Erics idea better I think.  My origional patch had two tables, and it
> seems that it made the early quirk detection logic that much more convoluted.
> This way each quirk can determine if it needs to be applied to more than one pci
> device.
>

nvidia or ati chip will come first, and then amd NB ( K8). So you need
to make sure "fix_applied return" is not going to skip your fix to
K8_NB.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/