linux-kernel - Re: [2.6 patch] drivers/pci/msi.c: move arch hooks to the top

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071211230015.GD14204@stusta.de>
Date:	Wed, 12 Dec 2007 00:00:15 +0100
From:	Adrian Bunk <bunk@...nel.org>
To:	Michael Ellerman <michael@...erman.id.au>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	linux-pci@...ey.karlin.mff.cuni.cz
Subject: Re: [2.6 patch] drivers/pci/msi.c: move arch hooks to the top

On Wed, Dec 12, 2007 at 09:44:10AM +1100, Michael Ellerman wrote:
> On Tue, 2007-12-11 at 23:19 +0100, Adrian Bunk wrote:
> > This patch fixes the following problem present with older gcc versions:
> > 
> > <--  snip  -->
> > 
> > ...
> >   CC      drivers/pci/msi.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/pci/msi.c:692: warning: weak declaration of `arch_msi_check_device' after first use results in unspecified behavior
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/pci/msi.c:704: warning: weak declaration of `arch_setup_msi_irqs' after first use results in unspecified behavior
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/pci/msi.c:724: warning: weak declaration of `arch_teardown_msi_irqs' after first use results in unspecified behavior
> > ...
> > 
> > <--  snip  -->
> 
> They're declared in <linux/msi.h>, I don't see what it's problem is.

Older gcc versions don't like that they cannot see that they are weak 
functions at the time when they are used.

I'm not sure whether the generated code does the right thing, but even 
if it does rearranging the code doesn't do any harm here.

> cheers

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/