lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Dec 2007 09:10:31 -0500 From: "Dmitry Torokhov" <dmitry.torokhov@...il.com> To: "Stephen Hemminger" <shemminger@...ux-foundation.org> Cc: "Pavel Machek" <pavel@....cz>, "Len Brown" <lenb@...nel.org>, "Andrew Morton" <akpm@...ux-foundation.org>, linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Fujitsu application panel driver Hi Stephen, On Oct 23, 2007 2:55 PM, Stephen Hemminger <shemminger@...ux-foundation.org> wrote: > +static void mail_led_set(struct led_classdev *led, > + enum led_brightness value) > +{ > + struct apanel *ap = container_of(led, struct apanel, mail_led); > + if (value) > + ap->led_bits |= 0x8000; > + else > + ap->led_bits &= ~0x8000; > + ap->led_bits = value; > + schedule_work(&ap->led_work); > +} I was just about to apply the driver (and I folded in the other 4 patches you sent to me) but then I noticed the code above. It looks like the conditional does not have any effect, ap->led_bits will be overwritten with the raw value anyway. Please advise. Thank you. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists