linux-kernel - Re: [PATCH -mm] x86 boot : export boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071212065524.GA28963@kroah.com>
Date:	Tue, 11 Dec 2007 22:55:24 -0800
From:	Greg KH <greg@...ah.com>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Huang, Ying" <ying.huang@...el.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Andi Kleen <ak@...e.de>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] x86 boot : export boot_params via sysfs

On Wed, Dec 12, 2007 at 12:42:48PM +0800, Dave Young wrote:
> On Dec 12, 2007 10:40 AM, Andrew Morton <akpm@...ux-foundation.org> wrote:
> > On Tue, 11 Dec 2007 16:49:09 +0000 "Huang, Ying" <ying.huang@...el.com> wrote:
> >
> > > This patch export the boot parameters via sysfs. This can be used for
> > > debugging and kexec.
> > >
> > > The files added are as follow:
> > >
> > > /sys/kernel/boot_params/data  : binary file for struct boot_params
> > > /sys/kernel/boot_params/version       : boot protocol version
> >
> > Your patch uses kobject_create_and_register() which was added in Greg's
> > driver tree as of 2.6.24-rc4-mm1.
> >
> > However for some reason kobject_create_and_register() has magically vanished
> > from Greg's current driver tree so I cannot carry this patch, sorry.
> 
> Seems kobject_create_and_register would be replaced by
> kobject_create_and_add, and the uevent handling would be separated
> from original create_and_register onefunction.

Yes, that is what has now changed.

> wait for greg's patches or modify to use:
> 
> kobject_init
> kobject_add
> kobject_uevent
> 
> BTW, I suspect whether the uevent is really needed for boot_params object.

Actually, for something as trivial as this, just use the
kobject_create_and_add() and don't worry about the uevent.  It should be
pretty trivial.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/