linux-kernel - Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200712130148.22727.mb@bu3sch.de>
Date:	Thu, 13 Dec 2007 01:48:22 +0100
From:	Michael Buesch <mb@...sch.de>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	akpm@...ux-foundation.org, mingo@...e.hu,
	linux-kernel@...r.kernel.org, linux@...mer.net,
	jonathan@...masters.org, matthias.kaehlcke@...il.com,
	kjwinchester@...il.com, mbuesch@...enet.de
Subject: Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

On Wednesday 12 December 2007 09:00:03 Daniel Walker wrote:
> 
> Signed-Off-By: Daniel Walker <dwalker@...sta.com>
> 
> ---
>  drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c |   30 ++++++++++++-------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> Index: linux-2.6.23/drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c
> ===================================================================
> --- linux-2.6.23.orig/drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c
> +++ linux-2.6.23/drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c
> @@ -43,7 +43,7 @@
>  
>  static struct bcm43xx_debugfs fs;
>  static char really_big_buffer[REALLY_BIG_BUFFER_SIZE];
> -static DECLARE_MUTEX(big_buffer_sem);
> +static DEFINE_MUTEX(big_buffer_mutex);

This driver is scheduled for removal, so I'd not touch it anymore
to avoid the possibility to introduce a lastminute regression.
The new drivers (b43 and b43legacy) have this fixed (in a different
way by completely removing it).

-- 
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/