linux-kernel - Re: [2.6 patch] videobuf-core.c locking fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1197539953.4729.19.camel@gaivota>
Date:	Thu, 13 Dec 2007 07:59:13 -0200
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Shane <gnome42@...il.com>
Cc:	Adrian Bunk <bunk@...sta.de>, Adrian Bunk <bunk@...nel.org>,
	Brandon Philips <brandon@...p.org>,
	linux-kernel@...r.kernel.org,
	video4linux-list <video4linux-list@...hat.com>
Subject: Re: [2.6 patch] videobuf-core.c locking fixes

> > e1f8b4a49d86746f699919531c17fd154787e308
> > diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c
> > index 81f77d2..c8a5cb5 100644
> > --- a/drivers/media/video/videobuf-core.c
> > +++ b/drivers/media/video/videobuf-core.c
> > @@ -909,7 +909,7 @@ ssize_t videobuf_read_stream(struct videobuf_queue *q,
> >         if (q->streaming)
> >                 goto done;
> >         if (!q->reading) {
> > -               retval = videobuf_read_start(q);
> > +               retval = __videobuf_read_start(q);
> >                 if (retval < 0)
> >                         goto done;
> >         }
> > @@ -982,7 +982,7 @@ unsigned int videobuf_poll_stream(struct file *file,
> >                                          struct videobuf_buffer, stream);
> >         } else {
> >                 if (!q->reading)
> > -                       videobuf_read_start(q);
> > +                       __videobuf_read_start(q);
> >                 if (!q->reading) {
> >                         rc = POLLERR;
> >                 } else if (NULL == q->read_buf) {
> >
> 
> Yes it does! I was just going to send the same patch myself :)

The patch seems ok to my eyes. I dunno why I forgot to replace those two occurrences on my patch :(

 
Cheers,
Mauro

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/