linux-kernel - Re: [PATCH 1/3] x86: clean up asm-x86/page*.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071213102110.GP8977@elte.hu>
Date:	Thu, 13 Dec 2007 11:21:10 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Glauber de Oliveira Costa <glommer@...il.com>
Subject: Re: [PATCH 1/3] x86: clean up asm-x86/page*.h


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Unify common definitions in page*.h.  To simplify other code, I added 
> typedefs for the value of pte/pmd/pud/pgd values, so they can be used 
> symbolically elsewhere without needing to have lots of 32/64/PAE 
> tests.
> 
> Also, add PAGETABLE_LEVELS define so that other definitions can test 
> for it directly rather than using indirect 32/64/PAE tests.
> 
> Signed-off-by: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@...rix.com>

hm, your patches dont build. This is the error i get:

 include/asm-generic/pgtable-nopmd.h:46:1: warning: this is the location of the previous definition
 In file included from include/asm/pgtable_32.h:86,
                 from include/asm/pgtable.h:131,
                 from include/linux/mm.h:39,
                 from include/linux/suspend.h:12,
                 from arch/x86/kernel/asm-offsets_32.c:12,
                 from arch/x86/kernel/asm-offsets.c:3:
 include/asm/pgtable-2level.h:55: error: redefinition of 'native_pte_clear'
 include/asm/pgtable-2level.h:43: error: previous definition of 'native_pte_clear' was here

config attached.

	Ingo

View attachment "config" of type "text/plain" (72600 bytes)