linux-kernel - Re: [PATCH 19/19] unify set_tss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4761469B.9060507@redhat.com>
Date:	Thu, 13 Dec 2007 12:50:03 -0200
From:	Glauber de Oliveira Costa <gcosta@...hat.com>
To:	Andi Kleen <ak@...e.de>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	glommer@...il.com, tglx@...utronix.de, mingo@...e.hu,
	ehabkost@...hat.com, jeremy@...p.org, avi@...ranet.com,
	anthony@...emonkey.ws, virtualization@...ts.linux-foundation.org,
	rusty@...tcorp.com.au, chrisw@...s-sol.org, rostedt@...dmis.org,
	hpa@...or.com, zach@...are.com, roland@...hat.com
Subject: Re: [PATCH 19/19] unify set_tss_desc

Andi Kleen wrote:
>> +static inline void pack_tss(tss_desc *tss, unsigned long addr,
>> +			   unsigned size, unsigned entry)
>> +{
>> +#ifdef CONFIG_X86_64
>> +		set_tssldt_descriptor(tss,
>> +			     addr, entry, size);
>> +#else
>> +		pack_descriptor(tss, (unsigned long)addr,
>> +				size,
>> +				0x80 | entry, 0);
> 
> It would be better if you just unified that first instead of ifdef'ing.
> I guess i386 could get a set_tssldt_descriptor() like wrapper
> around pack_descriptor(). 
Good point.

Thanks, Andi.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/