[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <476161AB.2080306@intel.com>
Date: Thu, 13 Dec 2007 08:45:31 -0800
From: "Kok, Auke" <auke-jan.h.kok@...el.com>
To: David Miller <davem@...emloft.net>
CC: gallatin@...i.com, joonwpark81@...il.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, jgarzik@...ox.com,
shemminger@...ux-foundation.org, jesse.brandeburg@...el.com
Subject: Re: [RFC] net: napi fix
David Miller wrote:
> From: Andrew Gallatin <gallatin@...i.com>
> Date: Thu, 13 Dec 2007 09:13:54 -0500
>
>> If the netif_running() check is indeed required to make a device break
>> out of napi polling and respond to an ifconfig down, then I think the
>> netif_running() check should be moved up into net_rx_action() to avoid
>> potential for driver complexity and bugs like the ones you found.
>
> That, or something like it, definitely sounds reasonable and much
> better than putting the check into every driver :-)
hear hear!
Auke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists