linux-kernel - Re: [Patch 3/8] Enhanced partition statistics: aoe fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Dec 2007 15:08:14 -0500
From:	"Ed L. Cashin" <ecashin@...aid.com>
To:	Jerome Marchand <jmarchan@...hat.com>
Cc:	linux-kernel@...r.kernel.org, axboe@...nel.dk
Subject: Re: [Patch 3/8] Enhanced partition statistics: aoe fix

On Thu, Dec 13, 2007 at 05:17:45PM +0100, Jerome Marchand wrote:
> Updates the enhanced partition statistics in ATA over Ethernet driver (not tested).

Acked-by: Ed L. Cashin <ecashin@...aid.com>

> Signed-off-by: Jerome Marchand <jmarchan@...hat.com>
> ---
>  aoecmd.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> diff -urNp -X linux-2.6/Documentation/dontdiff linux-2.6.orig/drivers/block/aoe/aoecmd.c linux-2.6/drivers/block/aoe/aoecmd.c
> --- linux-2.6.orig/drivers/block/aoe/aoecmd.c	2007-12-04 17:37:13.000000000 +0100
> +++ linux-2.6/drivers/block/aoe/aoecmd.c	2007-12-05 13:45:10.000000000 +0100
> @@ -648,10 +648,10 @@ aoecmd_ata_rsp(struct sk_buff *skb)
>  			struct gendisk *disk = d->gd;
>  			const int rw = bio_data_dir(buf->bio);
>  
> -			disk_stat_inc(disk, ios[rw]);
> -			disk_stat_add(disk, ticks[rw], duration);
> -			disk_stat_add(disk, sectors[rw], n_sect);
> -			disk_stat_add(disk, io_ticks, duration);
> +			all_stat_inc(disk, ios[rw], buf->sector);
> +			all_stat_add(disk, ticks[rw], duration, buf->sector);
> +			all_stat_add(disk, sectors[rw], n_sect, buf->sector);
> +			all_stat_add(disk, io_ticks, duration, buf->sector);
>  			n = (buf->flags & BUFFL_FAIL) ? -EIO : 0;
>  			bio_endio(buf->bio, n);
>  			mempool_free(buf, d->bufpool);

-- 
  Ed L Cashin <ecashin@...aid.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/