linux-kernel - SLUB: Remove useless masking of GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0712131246030.18254@schroedinger.engr.sgi.com>
Date:	Thu, 13 Dec 2007 12:48:30 -0800 (PST)
From:	Christoph Lameter <clameter@....com>
To:	akpm@...ux-foundation.org
cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...dy.linux-foundation.org>,
	Matt Mackall <mpm@...enic.com>,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: SLUB: Remove useless masking of GFP_ZERO

Remove a recently added useless masking of GFP_ZERO. GFP_ZERO is 
already masked out in new_slab() (See how it calls allocate_slab). No need 
to do it twice. This reverts the SLUB parts of 
7fd272550bd43cc1d7289ef0ab2fa50de137e767.

Cc: Linus Torvalds <torvalds@...dy.linux-foundation.org>
Cc: Matt Mackall <mpm@...enic.com>
Cc: Pekka Enberg <penberg@...helsinki.fi>
Signed-off-by: Christoph Lameter <clameter@....com>

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2007-12-13 12:41:34.000000000 -0800
+++ linux-2.6/mm/slub.c	2007-12-13 12:42:03.000000000 -0800
@@ -1468,9 +1468,6 @@ static void *__slab_alloc(struct kmem_ca
 	void **object;
 	struct page *new;
 
-	/* We handle __GFP_ZERO in the caller */
-	gfpflags &= ~__GFP_ZERO;
-
 	if (!c->page)
 		goto new_slab;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/