linux-kernel - Re: Print taint info in more places.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b14f3e280712131543s5467be5cjf3df6049fb6dc645@mail.gmail.com>
Date:	Thu, 13 Dec 2007 21:43:15 -0200
From:	"Mauricio Mauad Menegaz Filho" <mmauad@...il.com>
To:	"Andi Kleen" <andi@...stfloor.org>
Cc:	"Dave Jones" <davej@...hat.com>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: Print taint info in more places.

2007/12/13, Andi Kleen <andi@...stfloor.org>:
> Dave Jones <davej@...hat.com> writes:
>
> >  #define WARN_ON(condition) ({                                                \
> >       int __ret_warn_on = !!(condition);                              \
> >       if (unlikely(__ret_warn_on)) {                                  \
> > -             printk("WARNING: at %s:%d %s()\n", __FILE__,            \
> > -                     __LINE__, __FUNCTION__);                        \
> > +             printk(KERN_ERR "WARNING: at %s:%d %s() (%s)\n",        \
> > +                      __FILE__, __LINE__, __FUNCTION__,              \
> > +                      print_tainted());                              \
> >               dump_stack();                                           \
>
> Have you checked how this affects code size? It might be worth it
> now to do a out of line helper.
>

Have you checked how does spotting a bug is worth the extra size
sometimes (almost all the time)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/