linux-kernel - Re: 2.6.23.9-rt13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0712131903020.13748@gandalf.stny.rr.com>
Date:	Thu, 13 Dec 2007 19:06:35 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Remy Bohmer <linux@...mer.net>
cc:	LKML <linux-kernel@...r.kernel.org>,
	RT <linux-rt-users@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Gregory Haskins <ghaskins@...ell.com>
Subject: Re: 2.6.23.9-rt13


Hi Remy,

This would have been better to send this as two separate
patches. They are two different issues.

On Thu, 13 Dec 2007, Remy Bohmer wrote:
> If I compile -rt13 I get some compile warnings on ARM (AT91):
> 1) This one did not exist in rt1:
> In file included from kernel/sched.c:911:
> kernel/sched_rt.c: In function 'dec_rt_tasks':
> kernel/sched_rt.c:88: warning: unused variable 'highest_prio'

This is from Gregory Haskins' patch. He forgot to compile check for
warnings on UP again ;-)

> 2)  This one is there already for a much longer time:
> CC      kernel/rcupreempt.o
> kernel/rcupreempt.c:1001: warning: 'per_cpu__rcu_dyntick_snapshot'
> defined but not used

This was a merge conflict being solved incorrectly.

>
> Both warnings are fixed by the attached patch, but warning 2 needs some review.
> This var is defined twice in this file, 1 in the NO_HZ ifdef, and 1
> which seems to be not used.

Yeah, I'll look into it since I wrote that usage ;-)

Greg,

Can you merge the first part into your patch and resend it to me.

I'll look at the second one.

Thanks,

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/