linux-kernel - Re: [RFC PATCH 08/12] PAT 64b: coherent mmap and sysfs bin ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071214063424.GB10100@suse.de>
Date:	Thu, 13 Dec 2007 22:34:24 -0800
From:	Greg KH <gregkh@...e.de>
To:	David Miller <davem@...emloft.net>
Cc:	venkatesh.pallipadi@...el.com, ak@....de, ebiederm@...ssion.com,
	rdreier@...co.com, torvalds@...ux-foundation.org,
	airlied@...net.ie, davej@...hat.com, mingo@...e.hu,
	tglx@...utronix.de, hpa@...or.com, akpm@...ux-foundation.org,
	arjan@...radead.org, jesse.barnes@...el.com,
	linux-kernel@...r.kernel.org, suresh.b.siddha@...el.com
Subject: Re: [RFC PATCH 08/12] PAT 64b: coherent mmap and sysfs bin ioctl

On Thu, Dec 13, 2007 at 04:35:05PM -0800, David Miller wrote:
> From: Greg KH <gregkh@...e.de>
> Date: Thu, 13 Dec 2007 16:19:32 -0800
> 
> > On Thu, Dec 13, 2007 at 03:55:51PM -0800, venkatesh.pallipadi@...el.com wrote:
> > > Forward port of coherent-mmap.patch and sysfs-bin-ioctl.patch to x86 tree.
> > > 
> > > TBD: Do we need the ioctl interface to sysfs or get the type attribute
> > > through a different sysfs file. And then actually specify the attribute
> > > while doing pci_mmap_page_range ;-)
> > 
> > Woah!  No, no ioctls on sysfs files, sorry.  Not going to happen, do
> > this on a /dev file if you want to have ioctls...
> 
> Well since we told people to move over to sysfs for PCI
> accesses, and that's where mmap() is done via too,
> it should be no surprise that we run into problems when
> people want to set attributes for the mmap() as was done
> for the procfs case.
> 
> So you have two choices:
> 
> 1) Balk on the sysfs pci usage, and erase years of effort
>    of moving people over to sysfs.  Tell them to go back to
>    procfs so we can add the attribute setting via ioctl()
>    which is absolutely needed.

Ok, sorry, it wasn't blindingly obvious that this was for pci sysfs
devices that are mmaped, that makes a bit more sense.

But I'd like to see what ioctl is wanted here first.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/