linux-kernel - Re: [PATCH] ohci: avoid an unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 14 Dec 2007 00:56:18 -0800
From:	David Brownell <david-b@...bell.net>
To:	"Jan Beulich" <jbeulich@...ell.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ohci: avoid an unused variable warning

On Thursday 13 December 2007, Jan Beulich wrote:
> 
> With CONFIG_PM, but without CONFIG_PM_SLEEP, the intention of the
> conditional in ohci_pci_start() doesn't work since device_may_wakeup()
> references pdev only with the latter config option.

Yuck.  That means that runtime power management won't work correctly.

The same wakeup mechanisms that apply during SUSPEND and HIBERNATION
are also used for runtime PM(*) ... which is allowed by CONFIG_PM, and
which accordingly should not depend on PM_SLEEP.

I think the bug is that device_may_wakeup() now looks at CONFIG_PM_SLEEP
instead of just CONFIG_PM.

- Dave

(*) Although ACPI has problems with the notion of runtime PM.  For
    example, it ignores PCI PME# signaling until PM_SLEEP transitions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/