linux-kernel - Re: [PATCH] time: add an offline-cpu check in add_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p73lk7xfssz.fsf@bingen.suse.de>
Date:	Fri, 14 Dec 2007 11:56:44 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	miaox@...fujitsu.com
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] time: add an offline-cpu check in add_timer_on()

Miao Xie <miaox@...fujitsu.com> writes:

> Hi everyone,
>   I think we need a check in the function add_timer_on() to avoid adding a
> timer into the timer list of an offline cpu.
>
> This patch fixes this problem in add_timer_on().

No it doesn't -- it will just crash if a caller does that. If it's a real 
problem then you either need to fix the callers or change add_timer_on()
to transparently put it onto another CPU.

I don't think it's a real problem though because CPU offlining does
a stop machine and that should take care of most such races.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/