linux-kernel - Re: [PATCH] time: add an offline-cpu check in add_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.99999.0712141203230.10584@localhost.localdomain>
Date:	Fri, 14 Dec 2007 12:05:03 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andi Kleen <andi@...stfloor.org>
cc:	miaox@...fujitsu.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] time: add an offline-cpu check in add_timer_on()

On Fri, 14 Dec 2007, Andi Kleen wrote:

> Miao Xie <miaox@...fujitsu.com> writes:
> 
> > Hi everyone,
> >   I think we need a check in the function add_timer_on() to avoid adding a
> > timer into the timer list of an offline cpu.
> >
> > This patch fixes this problem in add_timer_on().
> 
> No it doesn't -- it will just crash if a caller does that. If it's a real 
> problem then you either need to fix the callers or change add_timer_on()
> to transparently put it onto another CPU.
> 
> I don't think it's a real problem though because CPU offlining does
> a stop machine and that should take care of most such races.

No. CPU offlining does not prevent code to try inserting a timer on a
offlined CPU. If there is a real problem with this we need to fix the
calling code. We should not insert it somewhere else magically.

Thanks,

	 tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/