[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1197643856.21927.7.camel@twins>
Date: Fri, 14 Dec 2007 15:50:56 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Trond Myklebust <trond.myklebust@....uio.no>
Cc: Kay Sievers <kay.sievers@...y.org>,
Nick Piggin <nickpiggin@...oo.com.au>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, Jens Axboe <jens.axboe@...cle.com>,
Fengguang Wu <fengguang.wu@...il.com>, greg@...ah.com,
Miklos Szeredi <miklos@...redi.hu>, Neil Brown <neilb@...e.de>
Subject: Re: per BDI dirty limit (was Re: -mm merge plans for 2.6.24)
On Fri, 2007-10-26 at 12:37 -0400, Trond Myklebust wrote:
> On Fri, 2007-10-26 at 16:48 +0200, Peter Zijlstra wrote:
>
> > Miklos, Trond: could you suggest a better fmt for the bdi_init_fmt() for your
> > respective filesystems?
> <snip>
> > Index: linux-2.6-2/fs/nfs/client.c
> > ===================================================================
> > --- linux-2.6-2.orig/fs/nfs/client.c
> > +++ linux-2.6-2/fs/nfs/client.c
> > @@ -678,7 +678,7 @@ static int nfs_probe_fsinfo(struct nfs_s
> > goto out_error;
> >
> > nfs_server_set_fsinfo(server, &fsinfo);
> > - error = bdi_init(&server->backing_dev_info);
> > + error = bdi_init_fmt(&server->backing_dev_info, "nfs-%s-%p", clp->cl_hostname, server);
>
> In our debugging printks, we usually use the superblock->s_id, but that
> only gets initialised later.
>
> I'd suggest passing the 'dev_name' from *_get_sb() into
> *_create_server().
I just realised that such a name would contain '/' and I'm quite sure
that makes filesystems unhappy.
Neil suggested using device numbers which would work, however I think
those might not be human friendly. While its easy to find the device
number of a given path (eg.: stat -c %d /), its rather hard to find the
path belonging to a given device number.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists