linux-kernel - Re: [PATCH] Don't mark cpufreq_stats_free_table with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071214094144.601dcddf.akpm@linux-foundation.org>
Date:	Fri, 14 Dec 2007 09:41:44 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Russell King <rmk+lkml@....linux.org.uk>
Cc:	Linux Kernel List <linux-kernel@...r.kernel.org>,
	Satyam Sharma <satyam@...radead.org>,
	David Jones <davej@...hat.com>
Subject: Re: [PATCH] Don't mark cpufreq_stats_free_table with __cpuexit

On Fri, 14 Dec 2007 13:45:48 +0000 Russell King <rmk+lkml@....linux.org.uk> wrote:

> Commit 55395ae72b6e5ae614d28df74158c47454652583 introduced:
> 
> `.exit.text' referenced in section `.init.text' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o
> 
> Never mark functions that may be called during run time or
> initialisation time with a section that may be (or have been)
> discarded.
> 
> It was mentioned in the commit comments that an exit-section function
> was being called from an init-section function.  This should _always_
> result in the patch being rejected.  It's just a big no no.
> 
> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> 
> diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
> index 8a45d0f..bf5f780 100644
> --- a/drivers/cpufreq/cpufreq_stats.c
> +++ b/drivers/cpufreq/cpufreq_stats.c
> @@ -164,7 +164,8 @@ freq_table_get_index(struct cpufreq_stats *stat, unsigned int freq)
>  	return -1;
>  }
>  
> -static void __cpuexit cpufreq_stats_free_table(unsigned int cpu)
> +/* functions called from init paths can not be marked for an exit section */
> +static void /*__cpuexit*/ cpufreq_stats_free_table(unsigned int cpu)
>  {
>  	struct cpufreq_stats *stat = cpufreq_stats_table[cpu];
>  	struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
> 

yu, thanks, I have a fix for this from Adrian queued for when Linus
resurfaces.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/