linux-kernel - Re: [PATCH] UML - Add asm/fixmap.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071214095840.28736204.akpm@linux-foundation.org>
Date:	Fri, 14 Dec 2007 09:58:40 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Dike <jdike@...toit.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	uml-devel <user-mode-linux-devel@...ts.sourceforge.net>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] UML - Add asm/fixmap.h include

On Fri, 14 Dec 2007 11:16:47 -0500 Jeff Dike <jdike@...toit.com> wrote:

> [ This needs to go into 2.6.24, as it fixes a build breakage seen on x86_64 ]
> 
> um_uaccess.h refers to FIXADDR_USER_*, so it should include fixmap.h.
> 
> I also changed the non-UML includes to use <> instead of "".
> 
> Signed-off-by: Jeff Dike <jdike@...ux.intel.com>
> ---
>  arch/um/include/um_uaccess.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6.22/arch/um/include/um_uaccess.h
> ===================================================================
> --- linux-2.6.22.orig/arch/um/include/um_uaccess.h	2007-12-13 10:09:22.000000000 -0500
> +++ linux-2.6.22/arch/um/include/um_uaccess.h	2007-12-13 15:11:42.000000000 -0500
> @@ -6,7 +6,8 @@
>  #ifndef __ARCH_UM_UACCESS_H
>  #define __ARCH_UM_UACCESS_H
>  
> -#include "asm/elf.h"
> +#include <asm/elf.h>
> +#include <asm/fixmap.h>
>  #include "sysdep/archsetjmp.h"
>  
>  #define __under_task_size(addr, size) \

arch/um/include/um_uaccess.h already includes fixmap.h.  Is this a -mm-only
fix?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/