linux-kernel - Re: FInal kprobes rollup patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 Dec 2007 09:50:15 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: FInal kprobes rollup patches


* Harvey Harrison <harvey.harrison@...il.com> wrote:

> Further unification work.  There is a possible behavior change on 
> X86_32 here.
> 
> is_IF_modifier(p->opcode)
> 
> to
> 
> is_IF_modifier(p->ainsn.insn)
> 
> Which should be equivalent, but is not purely cosmetic as the rest of 
> the unification so far.

hm, could you split this into two, the pure-equivalence and the 
possibly-modifying patch? (that way any potential breakage becomes 
bisectable) Same end result, just two commits instead of one.

also, did you manage to run/test kprobes (on 32-bit or 64-bit x86), and 
it worked fine?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/