linux-kernel - Re: [PATCH] [RFC] be more verbose when probing EDD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47656B9E.3040405@zytor.com>
Date:	Sun, 16 Dec 2007 10:17:02 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	devzero@....de
CC:	linux-kernel@...r.kernel.org, Matt.Domsch@...l.com
Subject: Re: [PATCH] [RFC] be more verbose when probing EDD

devzero@....de wrote:
>         /* Query EDD information */
>  #if defined(CONFIG_EDD) || defined(CONFIG_EDD_MODULE)
> -       query_edd();
> +        printf("Probing EDD (query Bios for boot-device information)\n");
> +        printf("If boot hangs here, you may have a buggy Bios. Try edd=skipmbr or edd=off");
> +        query_edd();
> +        printf("\rOK                                                                       \n");
>  #endif

This is awfully verbose.

I'd prefer something like:

printf("Probing EDD BIOS... ");
query_edd();
printf("ok\n");

[or even "failed"...]

Also, you really should look for the "quiet" command-line option and 
squelch the message.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/