linux-kernel - [PATCH] 2.6.24-rc5: Fix build with make O= if the top level Makefile is not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200712162250.18291.rjw@sisk.pl>
Date:	Sun, 16 Dec 2007 22:50:17 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Sam Ravnborg <sam@...nborg.org>
Subject: [PATCH] 2.6.24-rc5: Fix build with make O= if the top level Makefile is not present

Hi,

IMHO, something like the patch below is needed to fix builds with "make O=",
since after commit 18c32dac75b187d1a4e858f3cfdf03e844129f5e
"kbuild: fix building with O=.. options" the top-level Makefile is no longer
created automatically if it's not present at all.

Thanks,
Rafael


---
From: Rafael J. Wysocki <rjw@...k.pl>

Make the build system create the top-level Makefile for builds with "make O="
if it is not present already.

Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
---
 scripts/mkmakefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/scripts/mkmakefile
===================================================================
--- linux-2.6.orig/scripts/mkmakefile
+++ linux-2.6/scripts/mkmakefile
@@ -13,7 +13,7 @@
 test ! -r $2/Makefile -o -O $2/Makefile || exit 0
 # Only overwrite automatically generated Makefiles
 # (so we do not overwrite kernel Makefile)
-if ! grep -q Automatically $2/Makefile
+if (test -f $2/Makefile) && !(grep -q Automatically $2/Makefile)
 then
 	exit 0
 fi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/