linux-kernel - Re: [PATCH 4/4] x86: Final unification of local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4765B930.8010208@zytor.com>
Date:	Sun, 16 Dec 2007 15:48:00 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 4/4] x86: Final unification of local_{32|64}.h

Harvey Harrison wrote:
> 
> Do you have a stylistic preference between these two options:
> 
> Option 1) Rely on CPP string constant concatenation
> 
> // possibly include trailing space here to avoid remembering
> // leading space on the register names
> # define _ASM_INC "incl" 
> 
> static inline void local_inc(local_t *l)
> {
> 	__asm__ __volatile__(
> 		_ASM_INC " %0"
> 		:"+m" (l->a.counter));
> }
> 

This is what I have used up to this point, except including the space in 
the macro:

#define _ASM_INC " incl "

	_ASM_INC "%0"

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/