linux-kernel - Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200712160420.58500.s.L-H@gmx.de>
Date:	Sun, 16 Dec 2007 04:20:52 +0100
From:	Stefan Lippers-Hollmann <s.L-H@....de>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	"John W. Linville" <linville@...driver.com>,
	Michael Buesch <mb@...sch.de>,
	Daniel Walker <dwalker@...sta.com>, akpm@...ux-foundation.org,
	stefano.brivio@...imi.it, Ray Lee <ray-lk@...rabbit.org>,
	matthias.kaehlcke@...il.com, linux-kernel@...r.kernel.org,
	mbuesch@...enet.de, linux@...mer.net, kjwinchester@...il.com,
	jonathan@...masters.org, Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	bcm43xx-dev@...ts.berlios.de
Subject: Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

On Sonntag, 16. Dezember 2007, Rafael J. Wysocki wrote:
> On Saturday, 15 of December 2007, John W. Linville wrote:
> > On Sat, Dec 15, 2007 at 02:25:50AM +0100, Rafael J. Wysocki wrote:
> > > On Friday, 14 of December 2007, Michael Buesch wrote:
> > 
> > > > Either distributions have to install it automatically or people simply have
> > > > to read one or two lines of documentation.  That's just what I wanted to say.
> > > 
> > > It's not that simple.  For example, regression testing will be a major PITA
> > > if one needs to switch back and forth from the new driver to the old one in the
> > > process.
> > 
> > Not really true -- a single system can easily have firmware installed
> > for b43, b43legacy, and bcm43xx at the same time and switch back and
> > forth between them.
> > 
> > Given a functioning udev configuration, the persistent naming even
> > works so that your device stays as 'eth1' when switching to and
> > fro bcm43xx.
> 
> Well, this last bit doesn't work on my openSUSE 10.3.  Honest, guv. ;-)

The persistent interface naming rules of udev, at least up to 0.114-2 
(current debian unstable), seem to be easily confused if the driver names 
change for the same MAC address. This issue seems not to be b43 specific, 
it happens with zd1211rw --> zd1211rw_mac80211 (this one won't show up in 
mainline kernels), prism54 --> p54pci/ p54usb, out-of-tree RaLink legacy/ 
serialmonkey (which ignore interface renames through udev completely) --> 
rt2x00 just as well and I assume that it might also affect sk98lin --> 
skge/ sky and the upcomming e1000 --> e1000e transitions and similar 
situations.

> > I really think everyone is overstating the problem.
> 
> You might be right.

It is of course confusing to the user and might affect remote updates, but 
it's also easily fixed by removing the generated MAC address mappings and 
letting udev generate new ones (+ post processing, if needed) during the 
next boot.

> Greetings,
> Rafael

Regards
	Stefan Lippers-Hollmann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/