linux-kernel - Re: INITIO scsi driver fails to work properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4766AB2A.7000206@panasas.com>
Date:	Mon, 17 Dec 2007 19:00:26 +0200
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Olivier Galibert <galibert@...ox.com>
CC:	James Bottomley <James.Bottomley@...senPartnership.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Filippos Papadopoulos <psybases@...il.com>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: INITIO scsi driver fails to work properly

On Mon, Dec 17 2007 at 18:20 +0200, Olivier Galibert <galibert@...ox.com> wrote:
> On Mon, Dec 17, 2007 at 06:08:59PM +0200, Boaz Harrosh wrote:
>> Below fixes a deadly typo. Might as well be included in 2.6.24
> 
> You're sure ?  scsi_for_each_sg includes a (sg)++ already...
> 
> 
>>  		scsi_for_each_sg(cmnd, sglist, cblk->sglen, i) {
>>  			sg->data = cpu_to_le32((u32)sg_dma_address(sglist));
>>  			total_len += sg->len = cpu_to_le32((u32)sg_dma_len(sglist));
>> +			++sg;
>>  		}
> 
>   OG.
> --
Don't mix up between the here sg that points to a driver specific struct sg_entry
and the here sglist which points to struct scatterlist, and is named sg inside
the scsi_for_each_sg() macro. Please inspect the full code, the patch does not
show the complete information. I admit it's confusing.

Boaz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/