linux-kernel - Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c0942db0712171005w65bbb512p71a4f9b1fc65c6a7@mail.gmail.com>
Date:	Mon, 17 Dec 2007 10:05:35 -0800
From:	"Ray Lee" <ray-lk@...rabbit.org>
To:	"Eric Dumazet" <dada1@...mosbay.com>
Cc:	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Herbert Xu" <herbert@...dor.apana.org.au>,
	"John Reiser" <jreiser@...wagon.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>, security@...nel.org,
	tytso@....edu,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	mpm@...enic.com, linux-sparse@...r.kernel.org
Subject: Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)

On Dec 17, 2007 9:55 AM, Eric Dumazet <dada1@...mosbay.com> wrote:
> -               mid = (last - first) / 2 + first;
> +       while (low <= high) {
> +               mid = (low + high) / 2;

I think you just introduced a bug. Think about what happens if
low=high=MAX_LONG/2 + 1.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/