linux-kernel - Re: [PATCH] alsa: fix SNDRV_PCM_IOCTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0712170905490.14817@tm8103.perex-int.cz>
Date:	Mon, 17 Dec 2007 09:07:49 +0100 (CET)
From:	Jaroslav Kysela <perex@...ex.cz>
To:	Miguel BotÃ³n <mboton.lkml@...il.com>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] alsa: fix SNDRV_PCM_IOCTL_TTSTAMP value.

On Sun, 16 Dec 2007, Miguel Botón wrote:

> "[ALSA] Use posix clock monotonic for PCM and timer timestamps" introduces
> a bug that makes audio device unusable in some computers.
> 
> Signed-off-by: Miguel Botón <mboton@...il.com>

Thanks for notify that old alsa-lib binaries have trouble with this patch. 
But your fix is wrong. New and old ioctls are incompatible. I added old 
ioctl back to our HG tree.

					Jaroslav

> diff --git a/include/sound/asound.h b/include/sound/asound.h
> index 475eb71..d35aa44 100644
> --- a/include/sound/asound.h
> +++ b/include/sound/asound.h
> @@ -443,7 +443,7 @@ enum {
>  enum {
>  	SNDRV_PCM_IOCTL_PVERSION = _IOR('A', 0x00, int),
>  	SNDRV_PCM_IOCTL_INFO = _IOR('A', 0x01, struct snd_pcm_info),
> -	SNDRV_PCM_IOCTL_TTSTAMP = _IOW('A', 0x03, int),
> +	SNDRV_PCM_IOCTL_TTSTAMP = _IOW('A', 0x02, int),
>  	SNDRV_PCM_IOCTL_HW_REFINE = _IOWR('A', 0x10, struct snd_pcm_hw_params),
>  	SNDRV_PCM_IOCTL_HW_PARAMS = _IOWR('A', 0x11, struct snd_pcm_hw_params),
>  	SNDRV_PCM_IOCTL_HW_FREE = _IO('A', 0x12),
> 
> -- 
> 	Miguel Botón
> 

-----
Jaroslav Kysela <perex@...ex.cz>
Linux Kernel Sound Maintainer
ALSA Project