linux-kernel - Re: [PATCH 13/21] [PATCH] change bitwise operations to get a void parameter.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47675CF1.5070008@zytor.com>
Date:	Mon, 17 Dec 2007 21:38:57 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	Glauber de Oliveira Costa <gcosta@...hat.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	glommer@...il.com, tglx@...utronix.de, mingo@...e.hu,
	ehabkost@...hat.com, jeremy@...p.org, avi@...ranet.com,
	anthony@...emonkey.ws, virtualization@...ts.linux-foundation.org,
	ak@...e.de, chrisw@...s-sol.org, rostedt@...dmis.org,
	zach@...are.com, roland@...hat.com
Subject: Re: [PATCH 13/21] [PATCH] change bitwise operations to get a void
 parameter.

Rusty Russell wrote:
> On Tuesday 18 December 2007 09:52:36 Glauber de Oliveira Costa wrote:
>> This patch changes the bitwise operations in bitops.h to get
>> a void pointers as a parameter. Before this patch, a lot of warnings
>> can be seen. They're gone after it.
> 
> No, this is a backwards step!  These warnings are important for 
> non-arch-specific code: I fought hard to get them made into unsigned longs.
> 
> But I'm happy for this to be applied as is, then I'll grab the git tree, 
> revert it and fix the warnings...
> 

Yes, it's particularly nasty as it'll work fine on littleendian arches, 
and fail on bigendian arches...

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/