linux-kernel - Re: [PATCH] ia64: Avoid unnecessary TLB flushes when allocating memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071218152642.4761ae4a.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Tue, 18 Dec 2007 15:26:42 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Kyle McMartin <kyle@...artin.ca>
Cc:	"de Dinechin, Christophe (Integrity VM)" 
	<christophe.de-dinechin@...com>,
	"linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Picco, Robert W." <robert.picco@...com>,
	"tony.luck@...el.com" <tony.luck@...el.com>
Subject: Re: [PATCH] ia64: Avoid unnecessary TLB flushes when allocating
 memory

On Tue, 18 Dec 2007 01:00:15 -0500
Kyle McMartin <kyle@...artin.ca> wrote:

> On Tue, Dec 18, 2007 at 10:05:45AM +0900, KAMEZAWA Hiroyuki wrote:
> > On Thu, 13 Dec 2007 15:03:07 +0000
> > 
> > > +       if (mm != active_mm) {
> > > +               /* Restore region IDs for mm */
> > > +               if (mm && active_mm) {
> > > +                       activate_context(mm);
> > > +               } else {
> > > +                       flush_tlb_all();
> > > +                       return;
> > > +               }
> > >         }
> > should be 
> > 
> 
> platform_global_tlb_purge is already (and afaict, only) called under
> preempt_disable already. then again, the sn2 global_tlb_purge
> does it, so possibly for completeness sake it should be added here as
> well?
> 
Thank you. I see. flush_tlb_range() is the only caller.

...maybe adding comment is helpful (for me :).

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/