linux-kernel - Re: FInal kprobes rollup patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47671407.7050607@redhat.com>
Date:	Mon, 17 Dec 2007 19:27:51 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Harvey Harrison <harvey.harrison@...il.com>,
	Jim Keniston <jkenisto@...ibm.com>
CC:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Maneesh Soni <maneesh@...ux.vnet.ibm.com>,
	srinivasa@...ibm.com,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Masami Hiramatsu <hiramatu@....hitachi.co.jp>,
	Rusty Lynch <rusty.lynch@...el.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Keshavamurthy Anil S <anil.s.keshavamurthy@...el.com>
Subject: Re: FInal kprobes rollup patches

Masami Hiramatsu wrote:
>> These are:
>>
>> -add stack_addr() macro
>> -I prefer the table defintion macros in mine as it avoids the need to
>> cast the pointer passed to test_bit, but if you want them
>> to be u32 as in your patch, I can change it.
> 
>  please do so. we'd like to reduce ifdefs as less as possible:-)
> 
>> -wrmsr/wrmsrl - use wrmsr() for both
>> -call is_IF_modifier with p->ainsn.insn in both
>> -check casting of jprobe_saved_sp, I get some compile warnings currently
>> with pointer comparisons to signed/unsigned types.
> 
> Could you also add below?
> - fix some comments (it clarifies the meanings of the code)
> - add fix_riprel(). this useful to reduce ifdefs.
> - expand reenter_kprobe(). I think it treat above two blocks.
> - reassignment of regs->ip in kprobe_handler can be unified
>   to "regs->ip = (unsigned long)addr;"

Oh, I forgot to point out important thing.
- please make bugfix patches first. I think my bugfix patches
  need to go upstream before unification. It would cause some
  crashes.

Thank you.


-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com, masami.hiramatsu.pt@...achi.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/