linux-kernel - Re: [PATCH] usb/storage/initializers.c: fix signedness difference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071218153642.cf8c6a0b.akpm@linux-foundation.org>
Date:	Tue, 18 Dec 2007 15:36:42 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Marcin __lusarz <marcin.slusarz@...il.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb/storage/initializers.c: fix signedness difference

On Sun, 9 Dec 2007 22:23:42 +0100
Marcin __lusarz <marcin.slusarz@...il.com> wrote:

> usb/storage/initializers.c: fix signedness difference
> 
> Signed-off-by: Marcin __lusarz <marcin.slusarz@...il.com>
> ---
>  drivers/usb/storage/initializers.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/storage/initializers.c b/drivers/usb/storage/initializers.c
> index ee5b42a..187dd1e 100644
> --- a/drivers/usb/storage/initializers.c
> +++ b/drivers/usb/storage/initializers.c
> @@ -66,7 +66,8 @@ int usb_stor_ucr61s2b_init(struct us_data *us)
>  {
>  	struct bulk_cb_wrap *bcb = (struct bulk_cb_wrap*) us->iobuf;
>  	struct bulk_cs_wrap *bcs = (struct bulk_cs_wrap*) us->iobuf;
> -	int res, partial;
> +	int res;
> +	unsigned int partial;
>  	static char init_string[] = "\xec\x0a\x06\x00$PCCHIPS";
> 
>  	US_DEBUGP("Sending UCR-61S2B initialization packet...\n");

Often we just wouldn't bother about something this minor.

But I see later on that we pass the address of `partial' into some other
function and I am guessing that this produces some warning with some tool
which you didn't tell us about? 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/