linux-kernel - [PATCH 0/1] x86: fix show cpuinfo cpu number always zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20071218233514.501149000@sgi.com>
Date:	Tue, 18 Dec 2007 15:35:14 -0800
From:	travis@....com
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Andi Kleen <ak@...e.de>, Christoph Lameter <clameter@....com>,
	Jack Steiner <steiner@....com>,
	Suresh B Siddha <suresh.b.siddha@...el.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: [PATCH 0/1] x86: fix show cpuinfo cpu number always zero


It appears that this patch is missing from the latest 2.6.24 git
kernel as well as the 2.6.24-rc5-mm1 patch?

> Mike, This issue still seems to be present in linus git tree. Perhaps
> the fix in -mm not pushed to mainline yet.
> 
> Can you please raise the flag with Andrew, so that he can push it before
> 2.6.24 gets out
> 

-- 

>From travis@....com Tue Dec 18 15:35:14 2007
Message-Id: <20071218233514.634913000@....com>
References: <20071218233514.501149000@....com>
User-Agent: quilt/0.46-1
Date: Tue, 18 Dec 2007 15:35:15 -0800
From: travis@....com
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Andi Kleen <ak@...e.de>,
 Christoph Lameter <clameter@....com>,
 Jack Steiner <steiner@....com>,
 Suresh B Siddha <suresh.b.siddha@...el.com>,
 linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Bcc: travis@....com
Subject: [PATCH 1/1] x86: fix show cpuinfo cpu number always zero
Content-Disposition: inline; filename=cpuinfo_x86-fix

This fix corrects the problem that early_identify_cpu() sets
cpu_index to '0' (needed when called by setup_arch) after
smp_store_cpu_info() had set it to the correct value.

The error shows up in 'cat /proc/cpuinfo' will all cpus = 0.

Signed-off-by: Mike Travis <travis@....com>
---
 arch/x86/kernel/smpboot_64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/kernel/smpboot_64.c
+++ b/arch/x86/kernel/smpboot_64.c
@@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
 	struct cpuinfo_x86 *c = &cpu_data(id);
 
 	*c = boot_cpu_data;
-	c->cpu_index = id;
 	identify_cpu(c);
+	c->cpu_index = id;
 	print_cpu_info(c);
 }
 

-- 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/