linux-kernel - Re: [PATCH] x86: Fix dmi_alloc() to not advance alloc index in case of failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071219105036.GJ3521@elte.hu>
Date:	Wed, 19 Dec 2007 11:50:36 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Parag Warudkar <parag.warudkar@...il.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, ak@...e.de,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: Fix dmi_alloc() to not advance alloc index in
	case of failure


* Parag Warudkar <parag.warudkar@...il.com> wrote:

> dmi_alloc() for CONFIG_X86_64 is defined to allocate from a static 
> array and it maintains a allocation index which is advanced each time 
> allocation is attempted - it gets incremented even if an allocation 
> fails thereby depriving any future request that may be small enough to 
> be satisfied from the array.
>
> Fix this by first testing if allocation is going to be possible and 
> incrementing alloc index only then.

Thanks, applied. Nice catch!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/