linux-kernel - Re: [PATCH v3 7/8] debugfs: allow access to signed values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1198080034.4747.15.camel@johannes.berg>
Date:	Wed, 19 Dec 2007 17:00:34 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Stefano Brivio <stefano.brivio@...imi.it>
Cc:	"John W. Linville" <linville@...driver.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Mattias Nissler <mattias.nissler@....de>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 7/8] debugfs: allow access to signed values


> +static u64 debugfs_s8_get(void *data)


>  struct simple_attr {
> -	u64 (*get)(void *);
> +	unsigned long long (*get)(void *);

That seems wrong. Wouldn't you have to declare all the _get functions
with unsigned long long too now to avoid trouble on systems where u64 !=
unsigned long long?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)