linux-kernel - Re: [PATCH 1/2] x86: fix kprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <476940D0.30106@redhat.com>
Date:	Wed, 19 Dec 2007 11:03:28 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Jim Keniston <jkenisto@...ibm.com>,
	Roland McGrath <roland@...hat.com>, prasanna@...ibm.com,
	anil.s.keshavamurthy@...el.com, davem@...emloft.net,
	Harvey Harrison <harvey.harrison@...il.com>,
	systemtap-ml <systemtap@...rces.redhat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption

Hi Ingo,

Ingo Molnar wrote:
> * Masami Hiramatsu <mhiramat@...hat.com> wrote:
> 
>>> -			return 1;
>>> +			ret = 1;
>> Here, "return 1;" is correct. After single step is done, preemption is 
>> enabled in post_kprobe_handler().
> 
> could you resend the fixed patch? (instead of me fixing it up by hand - 
> which is error-prone)

Sure, I'll resend asap.

> 
> also, this seems like .24 material as well - could you send the fix 
> against -rc5 too?

-rc tree is fine. Actually, it was introduced by my cleanup patch.
Thanks!

> 
> 	Ingo

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com, masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/