linux-kernel - Re: [RFC, PATCH] sdio: move temporary buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071219175708.46c781ac@poseidon.drzeus.cx>
Date:	Wed, 19 Dec 2007 17:57:08 +0100
From:	Pierre Ossman <drzeus-list@...eus.cx>
To:	Marc Pignat <marc.pignat@...s.ch>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC, PATCH] sdio: move temporary buffer

On Wed, 19 Dec 2007 11:55:25 +0100
Marc Pignat <marc.pignat@...s.ch> wrote:

> Move the temporary buffer used by some sdio functions from sdio_func struct to
> the mmc_host struct and make it dma-safe.
> 
> Signed-off-by: Marc Pignat <marc.pignat@...s.ch>
> ---
> 
> There is no need to have this temporary buffer in every sdio_func, since all
> access to it are serialized by sdio_[claim/release]_host.
> 

I had some crazy idea about per function locking, but until that time this will do just fine.

> I also think it should be ____cacheline_aligned to make sure we have no data
> loss when doing dma syncing operations.

This is still voodoo to me, so I'll have to take your word for it. :)

> 
> Comments welcome!
> 

Looks good to me.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/