linux-kernel - Re: [PATCH] apm_event{,info}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1198090856.30771.236.camel@localhost.localdomain>
Date:	Wed, 19 Dec 2007 14:00:56 -0500
From:	Adam Jackson <ajax@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apm_event{,info}_t are userspace types.

On Wed, 2007-12-12 at 02:47 -0800, Andrew Morton wrote:
> On Fri, 30 Nov 2007 15:02:43 -0500 Adam Jackson <ajax@...hat.com> wrote:
> > These types define the size of data read from /dev/apm_bios.  They
> > should not be hidden behind #ifdef __KERNEL__.
> 
> Missing info: what are the consequences of this fix?  What id broken when
> it it not applied?

The X server won't build.  Neither will apmd, but it's harder for me to
get worked up about that.

> > ---
> >  include/linux/apm_bios.h |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> Please include Signed-off-by:, as per Documentation/SubmittingPatches,
> thanks.

Blah.  Right, will remember git-format-patch -s next time.  In any
event:

Signed-off-by: Adam Jackson <ajax@...hat.com>

- ajax

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/