linux-kernel - Re: Trying to convert old modules to newer kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0712192142060.5524@fbirervta.pbzchgretzou.qr>
Date:	Wed, 19 Dec 2007 21:47:08 +0100 (CET)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	"linux-os (Dick Johnson)" <linux-os@...logic.com>
cc:	Linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: Trying to convert old modules to newer kernels


On Dec 19 2007 15:10, linux-os (Dick Johnson) wrote:


>I got rid of __init and anything else that I thought could cause the fault,

I anticipate the day removing __init causes a breakage, heh.
I mean, if all in-tree modules and LDD3 use it, it can't be wrong, can it?

>plus got rid of all the code!
>static int32_t startup()

I noticed that. Where's your "void" gone? :-)
And usually, the init routine returns int, not int32_t,
even if it's the same in current development models.
(I don't think you run an ILP64-compiled kernel.)

#include <linux/autoconf.h> is also not advised.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/